|
From: | Paul Eggert |
Subject: | bug#39678: 'grep --ignore-case --color' does not always color the matches |
Date: | Tue, 19 Oct 2021 16:23:41 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 |
On 10/19/21 11:36, Tomasz Dziendzielski wrote:
I found that for optimization purposes common cases in re_string_peek_byte are missed if pstr->mbs_allocated is true, thus skipping them also for case insensitive.
Unfortunately I've lost context here. Is this patch being proposed to improve performance, or to fix a bug?
I don't see how the patch preserves correctness: if pstr->icase is true, surely in general we need to look at the translated string, not the original.
[Prev in Thread] | Current Thread | [Next in Thread] |