[bug #63218] [eqn] confusing diagnostics with some input characters

[G. Branden Robinson]

Update of bug #63218 (project groff):

                  Status:             In Progress => Fixed                  
             Open/Closed:                    Open => Closed                 
         Planned Release:                    None => 1.23.0                 

    _______________________________________________________

Follow-up Comment #3:


commit bbde17473b43ece9441c5844d3e6da3fc8513f8a
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Sat Oct 15 11:34:34 2022 -0500

    [eqn]: Improve unprintable character diagnostics.
    
    [eqn]: Improve diagnostics involving unprintable characters.
    
    * src/preproc/eqn/main.cpp (input_char_description): New function
      constructs a human-readable string describing characters.
    
      (read_line, inline_equation, main): Call new function and adjust
      diagnostic message wording to accommodate the phrase it returns.
    
    Fixes <https://savannah.gnu.org/bugs/?63218>.
    
    groff 1.22.4:
    
    $ echo | `printf 'eqn -dx\032\n'` >/dev/null
    eqn: bad delimiter ''
    $ printf '\001 x = x + 1\n' | `printf 'eqn -d\001\177\n'` > /dev/null
    eqn:<standard input>:2: fatal error: unterminated '' at line 1, looking
for ''
    $ printf '\001 x = x + 1\n' | `printf 'eqn -N -d\001\177\n'` > /dev/null
    eqn:<standard input>:1: missing ''
    
    groff now:
    
    $ echo | `printf './build/eqn -dx\032\n'` >/dev/null
    ./build/eqn: error: invalid delimiter (character code 26) in '-d' option
argument
    $ printf '\001 x = x + 1\n' | `printf './build/eqn -d\001\177\n'` >
/dev/null
    ./build/eqn:<standard input>:2: fatal error: unterminated inline equation;
started with a leader character, expecting a delete character
    $ printf '\001 x = x + 1\n' | `printf './build/eqn -N -d\001\177\n'` >
/dev/null
    ./build/eqn:<standard input>:1: error: unterminated inline equation;
started with a leader character, expecting a delete character



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?63218>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/