[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Parse mem= on Linux kernel command line to change initrd loa
|
From: |
Yoshinori K. Okuji |
|
Subject: |
Re: [PATCH] Parse mem= on Linux kernel command line to change initrd load address (resend) |
|
Date: |
Tue, 26 Mar 2002 05:42:41 +0900 |
|
User-agent: |
Wanderlust/2.8.1 (Something) SEMI/1.14.3 (Ushinoya) FLIM/1.14.3 (Unebigoryōmae) APEL/10.3 Emacs/21.1 (i386-debian-linux-gnu) MULE/5.0 (SAKAKI) |
At 20 Mar 2002 12:06:25 -0500,
Jeremy Katz wrote:
> There'd have to be a different version to handle unsigned longs, though,
> as you have to be able to handle a memory size of unsigned long
> (although people don't generally do mem=4294967296, it's perfectly valid
> to do so)
More precisely, you have to be able to handle unsigned long long,
because Pentium Pro and later processors can use up to 64GB. So, if
you want to make GRUB complete theoretically, simple_strtoul is not
enough, either.
But, as initrd cannot be put above 0x3C000000 anyway, GRUB doesn't
have to support such a large value. Instead, it would be enough to
check an overflow and set the upper limit to 0x3C000000 when it
occurs, right?
Thus, I'm going to add a type of error which indicates an overflow and
use it rather than ERR_NUMBER_PARSING in safe_parse_maxint.
Okuji