Re: Bug in grub 0.95

[Jeroen Dekkers]

At Tue, 15 Jun 2004 14:03:39 +0200,
Yoshinori K. Okuji wrote:
> 
> On Monday 14 June 2004 17:09, Jeroen Dekkers wrote:
> > Meino Christian Cramer wrote:
> > >      make[3]: Entering directory
> > > `/home/mccramer/tmp/grub-0.95/stage2' ffs_stage1_5 is too big (8448
> > > > 7168).
> > >      FAIL: size_test
> > >      =================================
> > >      1 of 1 tests failed
> > >      Please report to address@hidden
> > >      =================================
> >
> > This is actually expected and nonfatal. You can just ignore it.
> 
> It is true that this error is not very important, but I think it is 
> better not to ignore this error. Because, if Stage 1.5 becomes bigger, 
> Stage2 should become bigger as well. This does not affect anything, if 
> the size is still not too big. But if this exceeds available free space 
> before EBDA, this could be fatal.
> 
> Probably Meino specified CFLAGS and/or CPPFLAGS explicitly when 
> compiling GRUB. Since the default CFLAGS is quite optimized to reduce 
> the binary size, you should not try to alter the flags. We must add 
> this into the FAQ.

It seems to be that gcc 3.4 produces a stage 1.5 which is about 300
bytes bigger:
-rwxr-xr-x    1 jeroen   jeroen       8020 Jun 15 14:12 
grub-gcc3.4/stage2/e2fs_stage1_5
-rwxr-xr-x    1 jeroen   jeroen       7780 Jun 15 14:12 
grub-gcc3.4/stage2/fat_stage1_5
-rwxr-xr-x    1 jeroen   jeroen       7060 Jun 15 14:12 
grub-gcc3.4/stage2/ffs_stage1_5
-rwxr-xr-x    1 jeroen   jeroen       7092 Jun 15 14:12 
grub-gcc3.4/stage2/iso9660_stage1_5
-rwxr-xr-x    1 jeroen   jeroen       8544 Jun 15 14:12 
grub-gcc3.4/stage2/jfs_stage1_5
-rwxr-xr-x    1 jeroen   jeroen       7252 Jun 15 14:12 
grub-gcc3.4/stage2/minix_stage1_5
-rwxr-xr-x    1 jeroen   jeroen       9524 Jun 15 14:12 
grub-gcc3.4/stage2/reiserfs_stage1_5
-rwxr-xr-x    1 jeroen   jeroen       7336 Jun 15 14:12 
grub-gcc3.4/stage2/ufs2_stage1_5
-rwxr-xr-x    1 jeroen   jeroen       6676 Jun 15 14:12 
grub-gcc3.4/stage2/vstafs_stage1_5
-rwxr-xr-x    1 jeroen   jeroen       9404 Jun 15 14:12 
grub-gcc3.4/stage2/xfs_stage1_5

With gcc 3.3.3 this is:
-rwxr-xr-x    1 jeroen   jeroen       7744 Jun 15 14:10 
grub-gcc3.3/stage2/e2fs_stage1_5
-rwxr-xr-x    1 jeroen   jeroen       7472 Jun 15 14:10 
grub-gcc3.3/stage2/fat_stage1_5
-rwxr-xr-x    1 jeroen   jeroen       6752 Jun 15 14:10 
grub-gcc3.3/stage2/ffs_stage1_5
-rwxr-xr-x    1 jeroen   jeroen       6784 Jun 15 14:10 
grub-gcc3.3/stage2/iso9660_stage1_5
-rwxr-xr-x    1 jeroen   jeroen       8288 Jun 15 14:10 
grub-gcc3.3/stage2/jfs_stage1_5
-rwxr-xr-x    1 jeroen   jeroen       6944 Jun 15 14:10 
grub-gcc3.3/stage2/minix_stage1_5
-rwxr-xr-x    1 jeroen   jeroen       9184 Jun 15 14:10 
grub-gcc3.3/stage2/reiserfs_stage1_5
-rwxr-xr-x    1 jeroen   jeroen       7124 Jun 15 14:10 
grub-gcc3.3/stage2/ufs2_stage1_5
-rwxr-xr-x    1 jeroen   jeroen       6400 Jun 15 14:10 
grub-gcc3.3/stage2/vstafs_stage1_5
-rwxr-xr-x    1 jeroen   jeroen       9224 Jun 15 14:10 
grub-gcc3.3/stage2/xfs_stage1_5

But stage 2 is actually smaller:
-rw-r--r--    1 jeroen   jeroen     100338 Jun 15 14:12 
grub-gcc3.4/stage2/stage2

With gcc 3.3.3 this is:
-rw-r--r--    1 jeroen   jeroen     103154 Jun 15 14:10 
grub-gcc3.3/stage2/stage2

Those 300 bytes just make the difference whether make check fails or
succeeds.

Jeroen Dekkers