Re: A Simple If Condition support in grub config files Patch

[Marco Gerards]

Alban Crequy <address@hidden> writes:

> Le dimanche 31 octobre 2004 à 15:52, Muhammed Fawzy a écrit:
>> Dear Sir, 
>>     Attached is a patch i made to add a simple conditional statement to
>> the grub config file grub.conf
>>  
>> the statement looks like the following 
>>  
>>  
>> root (hd0, 0)
>> kernel somekernel 
>> if!exists some file
>>     kernel someotherkernel
>>  
>> This is the first time in my life I make a patch so i am waiting for
>> your comments.
>
> Hello,
>
> I think Yoshinori K. Okuji will not accept the patch because Grub didn't
> accept new features. However, you may push your patch on [1] as it may
> be usefull for someone. There is also Grub 2, still in developpement
> which accepts new features. (I am not a dev of grub, I don't know the
> features needed by grub 2)

There was a discussion about scripting support for GRUB 2.  That would
include an if statement.

There is no decision on how the syntax would look like.  Besides that,
GRUB 2 works completely differently so this patch will not work for
GRUB 2.

> [1] http://savannah.gnu.org/bugs/?group=grub
>
> The patch format is often the output of the "diff -Naur" command, all in
> one file, instead of sending a patch for each file. IMHO it is easier to
> apply.

Personally I prefer patches that have '-p' too.  That makes it easier
to review the patch.

> I remember someone wanted this feature, but I can't remember why. Can
> you give me a context where this feature is usefull?

For scripting support, there are a lot of uses.  For example booting a
specific OS depending on the time.  Some people requested that.  If
you look in the pupa-devel archives, you can find the examples Okuji
gave.

--
Marco