[bug #29007] "error: unknown command `terminal'" if terminal_output gfxterm is false

[Colin Watson]

URL:
  <http://savannah.gnu.org/bugs/?29007>

                 Summary: "error: unknown command `terminal'" if
terminal_output gfxterm is false
                 Project: GNU GRUB
            Submitted by: cjwatson
            Submitted on: Thu Feb 25 14:59:40 2010
                Category: Configuration
                Severity: Ordinary
                Priority: 5 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
         Originator Name: Colin King
        Originator Email: address@hidden
             Open/Closed: Open
         Discussion Lock: Any
                 Release: 
                 Release: Bazaar - trunk
         Reproducibility: None
         Planned Release: None

    _______________________________________________________

Details:

In https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/519358, Colin King
reports:

grub2 on an EFI firmware based machine reports the error message: "error:
uknown command `terminal'".

I believe this occurs because "terminal_output gfxterm" fails to initialise
(because we cannot probe or set the graphics mode) and then grub2 falls back
to trying to be backwardly compatible with terminal.mod that does not support
terminal_output by executing the non-existent command "terminal gfxterm".

The offending code is:

   if terminal_output gfxterm ; then true ; else
    # For backward compatibility with versions of terminal.mod that don't
    # understand terminal_output
    terminal gfxterm
  fi

A possible workaround that stops the error message is:

  if terminal_output gfxterm ; then true ; else
    # For backward compatibility with versions of terminal.mod that don't
    # understand terminal_output
    if terminal gfxterm ; then
      true
    fi
  fi

This seems to fix the problem on an EFI firmware based PC. I hope this does
not break the backward compatibility terminal.mod workaround too.




    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?29007>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/