[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [edk2] EFI_CONSOLE_CONTROL_PROTOCOL in OvmfPkg / grub2
From: |
Laszlo Ersek |
Subject: |
Re: [edk2] EFI_CONSOLE_CONTROL_PROTOCOL in OvmfPkg / grub2 |
Date: |
Mon, 01 Oct 2012 20:08:08 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.7) Gecko/20120825 Thunderbird/10.0.7 |
Hello Andrew,
On 10/01/12 17:19, Andrew Fish wrote:
> It is OK for Grub to check for the EFI_CONSOLE_CONTROL_PROTOCOL and
> set the system into a text mode if that is required. For example Macs
> support console control and boot with it in graphics (only) mode. So
> it seems like the bug is in handling systems that don't support
> EFI_CONSOLE_CONTROL_PROTOCOL, and that path needs to get cleaned up.
> Hopefully the OVMF will make it much easier to work on grub EFI
> support.
That's the strange thing; if grub_efi_locate_protocol() fails to find
EFI_CONSOLE_CONTROL_PROTOCOL in grub_efi_set_text_mode(), it simply
returns. It looks as if the protocol were located (which is surprising
because it's not part of the OVMF build) and then SetMode() did the
wrong thing.
Or maybe I mis-attributed the blame to grub_efi_set_text_mode()...
Thank you!
Laszlo