[bug #48228] grub-mkconfig assumes grub-probe will only produce 1 line of output, breaks with mirrored zfs volumes

[Will Rouesnel]

Follow-up Comment #2, bug #48228 (project grub):

I've attached grub.cfg from a system with the following setup:

  pool: ssdpool
 state: ONLINE
status: The pool is formatted using a legacy on-disk format.  The pool can
        still be used, but some features are unavailable.
action: Upgrade the pool using 'zpool upgrade'.  Once this is done, the
        pool will no longer be accessible on software that does not support
        feature flags.
  scan: scrub repaired 0 in 0h5m with 0 errors on Sat May 21 00:18:37 2016
config:

        NAME                                                     STATE     READ 
WRITE
CKSUM
        ssdpool                                                  ONLINE       0 
    0
    0
          mirror-0                                               ONLINE       0 
    0
    0
            ata-Samsung_SSD_850_EVO_250GB_S21MNXAG814168J-part1  ONLINE       0 
    0
    0
            ata-Samsung_SSD_850_EVO_250GB_S21MNXAG814170W-part1  ONLINE       0 
    0
    0

Both disks are root devices. I can boot from them successfully with the
previously attached patches with update-grub.

The problem is all my linux stanzas end up looking like this:

        echo    'Loading Linux 4.6.0-040600-generic ...'
        linux   /ROOT/mint-13@/boot/vmlinuz-4.6.0-040600-generic root=/dev/sdk1
/dev/sdj1 ro recovery nomodeset 
        echo    'Loading initial ramdisk ...'
        initrd  /ROOT/mint-13@/boot/initrd.img-4.6.0-040600-generic

The split newline in the root= is because grub-probe can and does output
multiple lines. I've also had the same problem with cryptomount stanzas (and
the same solution applies). In both cases, this is broken - this config will
not boot through grub unless I edit the lines out.

(file #37624)
    _______________________________________________________

Additional Item Attachment:

File name: grub.cfg                       Size:9 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?48228>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/