Re: Bug in grub-menulst2cfg

[Norman Shulman]

On Thu, Sep 22, 2016 at 2:52 PM, Andrei Borzenkov <address@hidden> wrote:

22.09.2016 21:08, Norman Shulman пишет:
> You're right; this patch only works for a single fallback entry, which is
> better than nothing.
>

Not really. If grub is currently booted using fallback entry, command
should fail, not set the same entry again.

> If you think nothing is better, then eliminating the first if-statement
> leaves a patch that at least fixes the NUM case.
>

This will be wrong in case of "fallback" then.

Right, but it will boot the first entry, which may be better than a reboot loop, which is what the current translation will do.

 

> A working NUM case makes it possible to work around the inability to save
> fallback. The example in "4.3.2 Booting fallback systems" can be rewritten
> as
>
> title A
> ...
> savedefault 1
>
> title B
> ...
> savedefault 2
>
> which is functionally equivalent.
>
> I'll think about how to handle a fallback list, but it seems hard.
>
>
> On Wed, Sep 21, 2016 at 11:31 PM, Andrei Borzenkov <address@hidden>
> wrote:
>
>> 21.09.2016 23:23, Norman Shulman пишет:
>>> I don't see how to open a bug in Bug Tracker, so I'm sending it to the
>> list.
>>>
>>> Legacy savedefault saves the current entry as the default boot entry if
>> no
>>> argument is specified. The translation only saves the first word of a
>>> multiword title.
>>>
>>> In addition, savedefault NUM and savedefault fallback are not supported.
>>>
>>> The attached patch to the latest git source fixes this.
>>>
>>
>> $fallback can be list of entries, while $saved_entry is expected to be
>> single menu entry. GRUB legacy documentation is unclear what "next
>> fallback" means here and what happens if you do several consecutive
>> "savedefault fallback" invocations, but it still explicitly says "next
>> fallback entry", not "list of fallback entries".
>>
>
>
>

--

Norman Shulman
Sr. Developer/Architect
N-Dimension Solutions Inc.
9030 Leslie St, Unit 300
Richmond Hill, ON L4B 1G2
Canada

Tel: 905 707-8884 x 226
Fax: 905 707-0886

This email and any files transmitted with it are solely intended for the use of the named recipient(s) and may contain information that is privileged and confidential. If you receive this email in error, please immediately notify the sender and delete this message in all its forms.