Re: [Bug-guile-ncurses] [PATCH 1/2] Add reference count to ITEM structs contained by SCMs

[John Darrington]

Thanks.

I was unable to build direct from the repo - I got this error:

'for' loop initial declarations are only allowed in C99 or C11 mode

Perhaps you will consider the attached patch.


I'll start testing the new version anyway.

Thanks, John


On Thu, May 26, 2016 at 04:32:31AM +0000, Mike Gran wrote:
     >    
     >      Not too excited about this idea, but, it is better that the present
     >      condition.
     > 
     > I thought a bit about this.  The only other reasonable solution I could 
think of
     > was to keep a hash table.  But that seemed like a lot of effort.   It 
does mean 
     > that one cannot use the userptr for any other purpose, but that kind of 
paradigm
     > doesn't fit into the scheme way of doing things anyway.
     > 
     > I wasn't too happy about having to cast from pointer to integer and back 
     > again.
     
     
     In the last few commits on master, I implemented something like
     your suggested patches with regard to menu items and refcounting.
     
     The work began at
     the following commit, and was patched up
     the following few commits. 
     
     
http://git.savannah.gnu.org/cgit/guile-ncurses.git/commit/?id=c3f20ee766c487f8d1d1c47152326e08b56cafb4
 
     
     
     I'm in the middle of a long slog to improve the granularity of the test 
suite,
     so I'll try to write some tests for this along the way.
     
     Thanks,
     
     Mike Gran

-- 
Avoid eavesdropping.  Send strong encryted email.
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.

0001-Allow-the-source-to-build-with-C89.patch
Description: Text Data

signature.asc
Description: Digital signature