bug-guile
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: scm_hash_fn_create_handle_x?


From: Masao Uebayashi
Subject: Re: scm_hash_fn_create_handle_x?
Date: Fri, 08 Jun 2001 14:27:29 +0900

> The reason Guile dumps core is that it wants to output a deprecation
> warning at a time when the deprecation mechanism has not been
> initialized yet.  It tried to output that warning because a
> automatically generated file hadn't been brought uptodate in your
> sources yet, and was still using a deprecated function.
> 
> What we could do is abort more cleanly in that case.

Ignoring `issue-deprecation-warning's before `scm_init_deprecation'
seems not so bad to me. So how about this?

Regards,
Masao


Index: libguile/deprecation.c
===================================================================
RCS file: /cvsroot/guile/guile/guile-core/libguile/deprecation.c,v
retrieving revision 1.7
diff -u -r1.7 deprecation.c
--- libguile/deprecation.c      2001/05/26 20:51:20     1.7
+++ libguile/deprecation.c      2001/06/08 05:25:58
@@ -56,8 +56,14 @@
 
 /* This is either a boolean (when a summary should be printed) or a
    hashtab (when detailed warnings shouold be printed).
+
+   XXX This is re-initialized by `scm_init_deprecation' but should be
+   initiailized here because `issue-deprecation-warning' may be
+   invoked, that is, deprecated symbols may be used before
+   `scm_init_deprecation' is called. So now we can't issue deprecation
+   messages before the function called. This needs to be improved.
 */
-SCM issued_msgs;
+SCM issued_msgs = SCM_BOOL_F;
 
 void
 scm_c_issue_deprecation_warning (const char *msg)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]