Re: Mac OS X .dylib not working

[Peter O'Gorman]

On 03/04/2011 12:47 PM, Ralf Wildenhues wrote:
> [ dropping bug-libtool ]
>
> Hi Peter,
>
> * Peter O'Gorman wrote on Fri, Mar 04, 2011 at 07:07:30PM CET:
> > Ok?
>
> A few copyright year bumps are missing.

Oh, yeah, will fix.

> Some minor nits inline below.

> > +AT_SETUP(darwin can lt_dlopen .dylib and .so files)
>
> Missing m4 quotes (for style only)

Ok.

> > +AT_CHECK([test "$shared_ext" != "$module_ext" || exit 77],
> > +         [], [ignore])
>
> You can drop arguments two and three here.

Ok.

> > +  int errors = 0;
>
> Isn't this lacking
>    LTDL_SET_PRELOADED_SYMBOLS();
>
> or was that needed only for static libs (which you've excluded earlier)?

It's only needed for static. This bit was copy&pasted from lt_dlopenext.at.

> > +    if (lt_dlexit () != 0)
> > +      errormsg = dlerrordup (errormsg);
>
> I'm not particularly fond of this coding style, where ownership
> information essentially gets lots once an error occurs in any
> of the commands.  Might be ok for a test like this, but not such
> a good example for users.  lt_dlexit could be warranted even if
> some error occurred before.  Anyway, I won't reject the patch for
> this.

Ok, to be honest I didn't even read much of this code, it's from 
lt_dlopenext.at.

> > +if test "$shlibpath_var" = PATH; then
>
> This looks wrong; shouldn't it be != here?  Otherwise, ...

Again, didn't read it!! Will look into it and fix the old test if it's 
wrong.

This bit is not needed or used in the new test anyway, will remove it.

Thanks for the quick review. I will adjust and push, probably tomorrow.

Peter