bug#15370: weirdness w/ uniform-vector-read! compat

[Mark H Weaver]

Hi Ian,

Ian Price <address@hidden> writes:

> Thien-Thi Nguyen <address@hidden> writes:
>
>> ERROR: In procedure uniform-vector-read!:
>> ERROR: In procedure get-bytevector-n!: Value out of range: 4
>>
>> FWIW, Guile 1.8.8 produces same output as ‘ok’ on a similar (sans the
>> ‘use-modules’ and ‘uniform-vector-element-size’ noise) input, so i think
>> this situation is a regression.  Am i missing something?
>
> You'll notice that if you supply the parameters directly
> e.g. (uniform-vector-read! uve port 0 1), it succeeds. That's enough to
> pin it down to the lines
>
>   c_end = SCM_UNBNDP (end) ? SCM_BYTEVECTOR_LENGTH (uvec) : scm_to_size_t 
> (end);
>   c_end *= c_width;
>
> in scm_uniform_vector_read_x in libguile/deprecated.c 
>
> Bytevector length returns the number of bytes, but end specifies the
> index. We should only be multiplying the latter, not the former. Simple
> fix is to fold the multiplication into the else branch of the
> conditional.

Indeed!

> Since this procedure is marked deprecated, I'd like to know how long it
> has left before I patch it. Little point fixing it if it's soon...

It will certainly not be removed in the 2.0.x release series, which will
remain in use for at least another year or so.  Therefore, this should
definitely be fixed.  Would you like to do it?

In any case, thanks for investigating!

     Mark