[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#67255: define-library does not support 'rename' directives
From: |
Timothy Sample |
Subject: |
bug#67255: define-library does not support 'rename' directives |
Date: |
Thu, 23 Nov 2023 10:12:19 -0600 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Hey,
Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
> Timothy Sample <samplet@ngyro.com> writes:
>
>> Fixes <https://bugs.gnu.org/67255>.
>> Reported by Maxim Cournoyer <maxim.cournoyer@gmail.com>.
>
> Nitpick: at least 'Reported-by' is a common git trailer, and these
> must appear at the bottom of the git commit.
That’s a fair point. I’m following what seems to be (from the commit
log) Guile’s convention here. See
$ git log --grep='^Report'
Whether it’s a good convention is probably out of scope here! :)
> It at least works for my use case (SRFI 128), so it's for sure an
> improvement :-). You can see it in action in the series I've sent today.
Hooray!
-- Tim