[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#49583: [PATH] gnu: Add transmission-remote-gtk.
From: |
Leo Famulari |
Subject: |
bug#49583: [PATH] gnu: Add transmission-remote-gtk. |
Date: |
Thu, 15 Jul 2021 16:56:27 -0400 |
On Thu, Jul 15, 2021 at 02:31:08PM -0400, Justin Veilleux wrote:
> From 426aa9bd6b758628249df7c0925179ce39054f29 Mon Sep 17 00:00:00 2001
> From: terramorpha <terramorpha@cock.li>
> Date: Thu, 15 Jul 2021 14:27:35 -0400
> Subject: [PATCH] gnu: Add transmission-remote-gtk.
>
> * gnu/packages/bittorrent.scm (transmission-remote-gtk): New variable.
Thanks! Overall looks good.
I ran `guix lint` on it and got these warnings which should be addressed:
/home/leo/work/guix/gnu/packages/bittorrent.scm:165:5:
transmission-remote-gtk@1.4.1: 'gettext' should probably be a native input
/home/leo/work/guix/gnu/packages/bittorrent.scm:161:0:
transmission-remote-gtk@1.4.1: parentheses feel lonely, move to the previous or
next line
/home/leo/work/guix/gnu/packages/bittorrent.scm:170:14:
transmission-remote-gtk@1.4.1: synopsis should start with an upper-case letter
or digit
/home/leo/work/guix/gnu/packages/bittorrent.scm:170:14:
transmission-remote-gtk@1.4.1: no article allowed at the beginning of the
synopsis
> + (arguments
> + `(#:tests? #f ; the tests fail
> + ))
We need more of an explanation for why the tests should be disabled. Did
you look into the failure and try to determine if it represents some
real problems?