[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#56030: The guix pull profile is too big
From: |
Maxime Devos |
Subject: |
bug#56030: The guix pull profile is too big |
Date: |
Thu, 21 Jul 2022 17:46:38 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 |
On 21-07-2022 17:11, ( wrote:
couldn't we just use `-DSHELL_PATH=/gnu/store/...`?
Using SHELL_PATH instead of the __guix_bin_sh sounds better, yes. But
it's not 'just use -DSHELL_PATH=', we still need to change 'system'
appropriately.
Would this not violate POSIX? Since, as far as I can see,
<https://pubs.opengroup.org/onlinepubs/9699919799/functions/system.html>
does not give the implementation license to implement system(3) as a
macro.
Probably. But does that really matter? The standard exists for a
reason, but we aren't aiming for POSIX certifications and it isn't the
law or something ... seems rather inconvenient for development outside a
build environment though, so perhaps SHELL_PATH could somehow fallback
to /bin/sh when outside a build environment.
We could do
```
int system(const char *command) {
return __guix_run_in_shell(command, __guix_bin_sh);
}
Needs a 'static' to avoid multiple definitions on the same thing, but
yes, that would avoid the macro problem (though not sufficient for some
FFI).
Greetings,
Maxime.
OpenPGP_0x49E3EE22191725EE.asc
Description: OpenPGP public key
OpenPGP_signature
Description: OpenPGP digital signature
bug#56030: The guix pull profile is too big, (, 2022/07/21