[bug-gv] [bug #17636] gv fails to honour X resources

[Christoph Berg]

URL:
  <http://savannah.gnu.org/bugs/?17636>

                 Summary: gv fails to honour X resources
                 Project: GNU gv
            Submitted by: myon
            Submitted on: Donnerstag 07.09.2006 um 11:20
                Category: Graphical User interface
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
                 Release: None

    _______________________________________________________

Details:

The following was submitted to Debian bug #148533. I can confirm that the
provided patch (by Bernhard Link) fixes the issue.

----------------

Gv first reads the current resources, then overwrites them with the
default values.

As easy test, try:
cat > scales <<EOF
GV.scales: Natural size,   1.200,  screen  \n\
        Pixel based,    1.200,  pixel   \n\
        0.950,          0.950
EOF
xrdb -merge scales
and fire up gv to see it still shows the default menu.

The bug is only a signle True where a False belongs and fixed with the
following patch:

diff -r -u gv-3.6.1/src/main.c gv-patched/src/main.c
--- gv-3.6.1/src/main.c 2004-12-07 00:36:57.000000000 +0100
+++ gv-patched/src/main.c       2006-07-22 14:46:52.450968089 +0200
@@ -607,7 +607,7 @@
      XrmDatabase db;
      INFMESSAGE(getting resources)
      db = resource_buildDatabase(gv_display,gv_class,gv_name,&argc,argv);
-     XrmCombineDatabase(db,&gv_database,True);
+     XrmCombineDatabase(db,&gv_database,False);
    }
 
 /*### initializing widget set and creating application shell
#########################*/

At this place gv_display are the current resources, while db consists
out of the default resource values. If overwrite is true, the default
ones overwrite the current ones in gv_databases, discarding anything the
user set via xrdb or in his .Xresources...






    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?17636>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.gnu.org/