Re: [bug-gv] Patch so gv supports _NET_WM_PID

[Bernhard R. Link]

* Robert Zinkov <address@hidden> [091119 23:03]:
> --- gv-3.6.7/src/main.old.c   2009-01-15 06:35:49.000000000 -0800
> +++ gv-3.6.7/src/main.c       2009-11-19 13:51:15.000000000 -0800
> @@ -1341,6 +1341,15 @@
>        }
>      }
>
> +    pid_t pid = getpid ();
> +    Atom net_wm_pid = XInternAtom(XtDisplay(toplevel), "_NET_WM_PID", False);
> +    XChangeProperty (XtDisplay(toplevel), XtWindow(toplevel),
> +                     net_wm_pid,
> +                     XA_CARDINAL, 32,
> +                     PropModeReplace,
> +                     (unsigned char *)&pid, 1);

That does not look right. You give a pointer to a pid_t and claim it is
a pointer to a Cardinal. If that ever are different sizes, there is no
way this can give a compiler warning about being wrong.

Hochachtungsvoll,
        Bernhard R. Link
-- 
"Never contain programs so few bugs, as when no debugging tools are available!"
        Niklaus Wirth