[bug-gv] Re: Bug#618449: gv segmentation fault

[Bernhard R. Link]

* Bernhard R. Link <address@hidden> [110315 16:39]:
> * address@hidden <address@hidden> [110315 13:40]:
> > Program received signal SIGSEGV, Segmentation fault.
> > __strcpy_ssse3 () at ../sysdeps/x86_64/multiarch/strcpy.S:94
> > 94      ../sysdeps/x86_64/multiarch/strcpy.S: No such file or directory.
> >         in ../sysdeps/x86_64/multiarch/strcpy.S
[...]
> This seems to be the strcpy in line 284 of src/scale.c.
> getenv("SSH_CLIENT")                             = "127.0.0.1 52697 22"
> strcpy(0x7fff4ba92600, 
> "\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377\377"...
[...]
> Which looks quite strange...

I think this is the missing stdlib.h, which in the Debian package is not
yet fixed. (But 1b39e3b2a29936ed1cf7870e9a1073377026f201 [2] alrady fixes this).

Without stdlib.h getenv is supposed to return integer, so the adress is
mangled and if the variable is set, a truncated pointer is used, of
course generating a segmentation fault.

I guess I should have looked at all buildd logs a bit more carefully,
on 64 bit architectures it outputs[1]:

scale.c:281: warning: implicit declaration of function 'getenv'
scale.c:281: warning: assignment makes pointer from integer without a cast
scale.c:290: warning: comparison between pointer and integer
scale.c:290: warning: comparison with string literal results in unspecified 
behavior
scale.c:290: warning: assignment makes integer from pointer without a cast

So no bug in upstream gv left and Debian gv needs another upload with
this. (Though some new upstream release would be nice, there have quite
some patched piled up).

        Bernhard R. Link

[1] 
https://buildd.debian.org/fetch.cgi?pkg=gv;ver=1%3A3.7.1-2;arch=amd64;stamp=1297939314
[2] 
http://git.savannah.gnu.org/cgit/gv.git/commit/?id=1b39e3b2a29936ed1cf7870e9a1073377026f201