[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [patch] fix install of symlinks with DESTDIR in gzip-1.3.7
From: |
Paul Eggert |
Subject: |
Re: [patch] fix install of symlinks with DESTDIR in gzip-1.3.7 |
Date: |
Thu, 07 Dec 2006 16:11:04 -0800 |
User-agent: |
Gnus/5.1008 (Gnus v5.10.8) Emacs/21.4 (gnu/linux) |
Thanks for reporting that. I installed the following
slightly-different fix instead. It uses chdir instead. This makes
the transcript a bit harder to follow, but the makefile a bit simpler,
and right now I'm striving for simplicity.
2006-12-07 Paul Eggert <address@hidden>
* Makefile.am (install-exec-hook): Fix bug when installing
symbolic links as aliases. Problem reported by Mike Frysinger.
--- Makefile.am 7 Dec 2006 07:23:35 -0000 1.15
+++ Makefile.am 8 Dec 2006 00:08:41 -0000
@@ -79,16 +79,16 @@
transform='$(transform)'; \
test "X$$prog" = "X$$prog_ext" || \
transform="$$transform"';s/$$/$(EXEEXT)/'; \
- source=$(DESTDIR)$(bindir)/`echo "$$prog"|sed "$$transform"`; \
+ destbindir=$(DESTDIR)$(bindir); \
+ source=`echo "$$prog"|sed "$$transform"`; \
for alias in $$aliases; do \
- dest=$(DESTDIR)$(bindir)/`echo "$$alias"|sed "$$transform"`; \
+ dest=`echo "$$alias"|sed "$$transform"`; \
(set -x; \
+ cd "$$destbindir" && \
rm -f "$$dest" && \
case $@ in \
install-exec-hook) \
- for ln in ln "$(LN_S)"; do \
- $$ln "$$source" "$$dest" && break; \
- done;; \
+ ln "$$source" "$$dest" || $(LN_S) "$$source" "$$dest";; \
esac \
) || exit; \
done; \