RE: gzip use of memcpy

[Alain Magloire]

> > Index: inflate.c
> ...
> >          if (w - d >= e)
> >          {
> > -          memcpy(slide + w, slide + d, e);
> > +          memmove(slide + w, slide + d, e);
> 
> Can you give sample values of w, d and e for which this change
> makes a difference?  Doesn't the preceding (w - d >= e) guard
> ensure that the source and destination buffers never overlap?
>

According to our tester:

The w==16316
    d==16322
    w-d == -6  // <-- Unsigned
 
The bad file is an attachment; you could override the memcpy(3)
implementation with one checking for overlap for example.


Thanks

sella1.tar.gz
Description: sella1.tar.gz