[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: hello 2.1.91 pretest

From: Ralf Wildenhues
Subject: Re: hello 2.1.91 pretest
Date: Mon, 21 Aug 2006 10:50:48 +0200
User-agent: Mutt/1.5.12 (2006-08-10)

Hello Mark,

* Mark D. Baushke wrote on Mon, Aug 21, 2006 at 10:37:06AM CEST:
> Ralf Wildenhues <address@hidden> writes:
> > 
> > Suggested patch below.  OK?
> I like your change as I think it makes it easier to understand.

Thanks.  I'll apply in a day or two if noone objects.

> I suggest you add quotes around $module (i.e., "$module") to be
> consistent with all of the other uses (see for example the case in
> func_verify_nontests_module()).

But the word after `case' is not split by the shell, so the quoting is
not necessary here (just like the right hand side of an assignment).
There are people who feel that quoting should be added anyway, for
consistency, and so they would not have to remember this "exception".
But I would say: it strikes _me_ as inconsistent, and I try to never
quote the word after `case'.  I've once been bitten by a
  case $foo

where I silently had _expected_ word-splitting to take place (more
precisely, I expected a TAB in `$foo' to be turned into a space), but
which in fact doesn't.  Since then I really frown upon quoting there:
you don't need to, and not doing so consistently helps make me stay
aware of this.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]