[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: fifo, mmap, errors [better patch]
From: |
Roland McGrath |
Subject: |
Re: fifo, mmap, errors [better patch] |
Date: |
Fri, 5 Sep 2003 21:12:43 -0400 (EDT) |
> +2003-09-05 Greg Buchholz <greg@sleepingsquirrel.org>
Standard form is to include ChangeLog fragments as plain text before your
patch, not as part of the patch. Please do that in future.
> + * tunnel.c (trivfs_S_io_map): Changed return value to EOPNOTSUPP
Punctuate sentences.
> diff -bBrw -U2 old/pfinet/tunnel.c hurd/pfinet/tunnel.c
Don't use -b unless you take great care. This patch results in bad
indentation.
> +2003-09-05 Greg Buchholz <greg@sleepingsquirrel.org>
> +
> + * fifo.c, new-fifo.c, null.c (trivfs_S_io_map): Change return value to
> + EOPNOTSUPP (was EINVAL).
> +
This part I've applied.
Thanks,
Roland
- fifo, mmap, errors, Greg Buchholz, 2003/09/04
- Re: fifo, mmap, errors, Marcus Brinkmann, 2003/09/05
- Re: fifo, mmap, errors [patch], Greg Buchholz, 2003/09/05
- Re: fifo, mmap, errors [patch], Marco Gerards, 2003/09/05
- Re: fifo, mmap, errors [patch], Roland McGrath, 2003/09/06
- Re: fifo, mmap, errors [better patch], Greg Buchholz, 2003/09/05
- Re: fifo, mmap, errors [better patch], Michael Banck, 2003/09/06
- Re: fifo, mmap, errors [better patch], Alfred M. Szmidt, 2003/09/06
- Re: fifo, mmap, errors [better patch], Ognyan Kulev, 2003/09/06
- Re: fifo, mmap, errors [better patch], Marco Gerards, 2003/09/06
- Re: fifo, mmap, errors [better patch],
Roland McGrath <=
Re: fifo, mmap, errors, Roland McGrath, 2003/09/06