[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Incorrect offset for mouse data
From: |
Marcus Brinkmann |
Subject: |
Re: Incorrect offset for mouse data |
Date: |
Mon, 29 Mar 2004 01:30:28 +0200 |
User-agent: |
Wanderlust/2.10.1 (Watching The Wheels) SEMI/1.14.6 (Maruoka) FLIM/1.14.6 (Marutamachi) APEL/10.6 Emacs/21.3 (i386-pc-linux-gnu) MULE/5.0 (SAKAKI) |
At Fri, 26 Mar 2004 20:14:33 +0100,
marco_g wrote:
> In hurd/console.h there is the macro `CONS_MOUSE_OFFSET_BASE'.
> According to the documentation I read about the xterm terminal
> capabilities it should be set to 040 (octal), which is 0x20. It is
> currently set to 0x21. This needs to be fixed before the console can
> support a mouse driver (like xterm does).
>
> Here is a patch to fix this problem. Is it ok to apply this?
Sure. Note that this is probably an off-by-one error that depends on
how you define how you enumerate the rows/columns or so. I might have
made a honest mistake or just counted differently. It doesn't matter
much either way, as long as we interpret it consistently. That said,
0x20 is a "rounder" value and is probably what everybody else uses (or
should use). So, put it in, please.
I don't remember reading documentation about this, btw. I think I
just figured it out by experiment, or looking at some source, I don't
remember where I got it from.
Thanks,
Marcus