[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Devnode: Fix the pseudo-master device port opening flags.
From: |
Da Zheng |
Subject: |
Re: [PATCH] Devnode: Fix the pseudo-master device port opening flags. |
Date: |
Fri, 25 Dec 2009 23:18:34 +0800 |
User-agent: |
Thunderbird 2.0.0.23 (Macintosh/20090812) |
Hi,
Sergiu Ivanov wrote:
>> Maybe devnode can detect the access right of .MASTER first before it
>> calls file_name_lookup(). So if the user doesn't have write access
>> to .MASTER, it just makes its own node read-only. If the user want
>> to change the access right of the devnode node and want to have
>> write access, he just fails. I don't know if it sounds
>> reasonable. just my thought.
>
> This sounds pretty reasonable to me :-) It would require an extra
> check and another file_name_lookup, so it's an easy thing to change.
> However, taking into consideration the fact that antrik answers
> E-mails pretty fast these days, I'd suggest waiting for his final
> acknowledgement.
>
> Not that I'd consider your suggestion inappropriate, but antrik might
> introduce a completely new point of view, which could change things.
Certainly, if you are going to change it, then it depends on your decision. I
just provide some ideas.
By the way, do you celebrate Christmas? I think the mailing list is going to be
quiet for a while.
Zheng Da