[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] Implement some (global) symlinks.
|
From: |
olafBuddenhagen |
|
Subject: |
Re: [PATCH 2/2] Implement some (global) symlinks. |
|
Date: |
Fri, 13 Aug 2010 17:02:56 +0200 |
|
User-agent: |
Mutt/1.5.20 (2009-06-14) |
Hi,
On Fri, Aug 13, 2010 at 06:06:42AM +0200, Jeremie Koenig wrote:
> * /proc/cmdline -> /proc/2/cmdline (pid 2 is usually gnumach)
> This is not perfect, as the format of /proc/cmdline and /proc/*/cmdline are
> different on Linux. Namely, the latter includes NUL bytes to separate
> subsequent arguments, while the former contains only spaces.
>
> * /proc/mounts -> /etc/mtab
> libext2fs and some other stuff sometimes insists that this file must exist.
Hm... Perhaps these two changes should be split? Although the
implementation is the same, they are pretty much unrelated... Not sure
it's worth the trouble though. (Especially as it would actually require
three patches -- one for the common symlink handling part, and two for
the individual nodes.)
Regardless of that, I think you should split off the change from heap to
stack allocation into an extra patch. I assume it fixes a memory leak,
and that's certainly a good thing; but it's unrelated to the actual
changes you need here...
-antrik-
- [PATCH 1/2] Fix /proc/*/cmdline., Jeremie Koenig, 2010/08/13
- [PATCH 2/2] Implement some (global) symlinks., Jeremie Koenig, 2010/08/13
- Re: [PATCH 1/2] Fix /proc/*/cmdline., olafBuddenhagen, 2010/08/13
- [PATCH 2/4] update_pid_entries(): fix awkwardly indented uninitialized memory leak, Jeremie Koenig, 2010/08/13
- [PATCH 3/4] Set an appropriate st_mode on symlinks., Jeremie Koenig, 2010/08/13
- Re: [PATCH 3/4] Set an appropriate st_mode on symlinks., olafBuddenhagen, 2010/08/15
- Re: [PATCH 3/4] Set an appropriate st_mode on symlinks., Jeremie Koenig, 2010/08/15
- [PATCH 4/4] Implement /proc/cmdline and /proc/mounts as symlinks., Jeremie Koenig, 2010/08/13