[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 8/8] sysvinit: Fix getty path in /etc/inittab on Hurd.
From: |
Ivan Shmakov |
Subject: |
Re: [PATCH 8/8] sysvinit: Fix getty path in /etc/inittab on Hurd. |
Date: |
Tue, 09 Jul 2013 10:59:01 +0000 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux) |
>>>>> Justus Winter <4winter@informatik.uni-hamburg.de> writes:
> This is essentially the same as
> 89f6476d8979174f395a1bf784486254464c349d but fixes the existing
> /etc/inittab file in the postinstall script.
[…]
> + * sysvinit.postinst: Fix getty path in /etc/inittab on Hurd.
Please note that the GNU Coding Standards recommend to use the
“file name” term here instead:
--cut: https://www.gnu.org/prep/standards/standards.html --
Please do not use the term “pathname” that is used in Unix
documentation; use “file name” (two words) instead. We use the term
“path” only for search paths, which are lists of directory names.
--cut: https://www.gnu.org/prep/standards/standards.html --
(The last component of a file name — that is, a file name
without the leading directories — could then presumably be
called “base name.”)
[…]
> +if [ "$(uname)" = GNU ]; then
> + sed -i -e 's|/libexec/getty|/sbin/getty|' /etc/inittab
I don’t seem to understand. Shouldn’t it be the other way
around?
But overall, I doubt that this change is necessary. If the
package is being upgraded, the chances are that this defect was
already corrected by the user. And for the new installations,
wasn't this issue already fixed?
> +fi
> +
--
FSF associate member #7257
- [PATCH 3/8] initscripts: use pidof -s /sbin/init for robustness, (continued)
- [PATCH 3/8] initscripts: use pidof -s /sbin/init for robustness, Justus Winter, 2013/07/09
- [PATCH 7/8] sendsigs, killprocs: Disable on Hurd. killall5 kills essential processes., Justus Winter, 2013/07/09
- [PATCH 4/8] initscripts: add runsystem.sysv, Justus Winter, 2013/07/09
- [PATCH 5/8] initscripts: Disable rootcheck on Hurd, Justus Winter, 2013/07/09
- [PATCH 6/8] killall5.c: Use sysconf(_SC_SYMLOOP_MAX) instead of MAXSYMLINKS., Justus Winter, 2013/07/09
- [PATCH 8/8] sysvinit: Fix getty path in /etc/inittab on Hurd., Justus Winter, 2013/07/09
- Re: [PATCH 8/8] sysvinit: Fix getty path in /etc/inittab on Hurd.,
Ivan Shmakov <=
- Re: [PATCH 8/8] sysvinit: Fix getty path in /etc/inittab on Hurd., Pino Toscano, 2013/07/22
Re: patches for sysvinit, debian repository for testing, Samuel Thibault, 2013/07/15