Re: [PATCH 01/11] libshouldbeinlibc: fix minor port leak in maptime_map

[Samuel Thibault]

Justus Winter, le Wed 27 Nov 2013 13:31:08 +0100, a écrit :
> Deallocate the device port after creating the mapping. The mapping is
> independent of the device port.
> 
> * libshouldbeinlibc/maptime.c (maptime_map): Deallocate device port.

Ack.

> ---
>  libshouldbeinlibc/maptime.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/libshouldbeinlibc/maptime.c b/libshouldbeinlibc/maptime.c
> index ca35c6c..f0b69db 100644
> --- a/libshouldbeinlibc/maptime.c
> +++ b/libshouldbeinlibc/maptime.c
> @@ -51,6 +51,10 @@ maptime_map (int use_mach_dev, char *dev_name,
>       return err;
>  
>        err = device_map (device, VM_PROT_READ, 0, sizeof *mtime, &memobj, 0);
> +
> +      /* Deallocate the device port.  The mapping is independent of
> +      this port.  */
> +      mach_port_deallocate (mach_task_self (), device);
>      }
>    else
>      {
> -- 
> 1.7.10.4
> 

-- 
Samuel
Pour un père, autant mourir que de faire plein de calculs et pas s'occuper
de son fils
 -+- y sur #ens-mim - sombres histoires de zombies -+-