[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/11] libports: improve error handling in ports_reallocate_f
From: |
Samuel Thibault |
Subject: |
Re: [PATCH 05/11] libports: improve error handling in ports_reallocate_from_external |
Date: |
Wed, 27 Nov 2013 22:45:39 +0100 |
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Justus Winter, le Wed 27 Nov 2013 13:31:12 +0100, a écrit :
> * libports/reallocate-from-external.c (ports_reallocate_from_external):
> Improve error handling.
Ditto, ack.
> ---
> libports/reallocate-from-external.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/libports/reallocate-from-external.c
> b/libports/reallocate-from-external.c
> index cd12143..8cccb2a 100644
> --- a/libports/reallocate-from-external.c
> +++ b/libports/reallocate-from-external.c
> @@ -60,7 +60,8 @@ ports_reallocate_from_external (void *portstruct,
> mach_port_t receive)
> pi->cancel_threshold = 0;
> pi->mscount = stat.mps_mscount;
>
> - hurd_ihash_add (&pi->bucket->htable, receive, pi);
> + err = hurd_ihash_add (&pi->bucket->htable, receive, pi);
> + assert_perror (err);
> pthread_mutex_unlock (&_ports_lock);
>
> mach_port_move_member (mach_task_self (), receive, pi->bucket->portset);
> --
> 1.7.10.4
>
--
Samuel
<L> pour moi le seul qui est autorisé à fasciser, c moi :-)
- [PATCH 01/11] libshouldbeinlibc: fix minor port leak in maptime_map, Justus Winter, 2013/11/27
- [PATCH 03/11] proc: update comments, Justus Winter, 2013/11/27
- [PATCH 04/11] libports: improve error handling in ports_reallocate_port, Justus Winter, 2013/11/27
- [PATCH 02/11] init: fix port leak, Justus Winter, 2013/11/27
- [PATCH 05/11] libports: improve error handling in ports_reallocate_from_external, Justus Winter, 2013/11/27
- Re: [PATCH 05/11] libports: improve error handling in ports_reallocate_from_external,
Samuel Thibault <=
- [PATCH 06/11] libports: improve error handling in ports_transfer_right, Justus Winter, 2013/11/27
- [PATCH 07/11] libdiskfs: improve error reporting in diskfs_start_disk_pager, Justus Winter, 2013/11/27
- [PATCH 10/11] proc: store the privileged host port in _hurd_host_priv, Justus Winter, 2013/11/27
- [PATCH 09/11] libports: improve error reporting in adjust_priority, Justus Winter, 2013/11/27
- [PATCH 08/11] libfshelp: improve error handling in fshelp_start_translator_long, Justus Winter, 2013/11/27