[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 09/66] device/blkio.c: remove function
From: |
Samuel Thibault |
Subject: |
Re: [PATCH 09/66] device/blkio.c: remove function |
Date: |
Sun, 8 Dec 2013 23:49:51 +0900 |
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Marin Ramesa, le Thu 05 Dec 2013 22:03:03 +0100, a écrit :
> Function block_io_mmap() is never a dev op, therefore it is
> unused and it can be written again easily if needed.
> - if (device->dev_ops->d_mmap == block_io_mmap) {
> - d->type = DEV_PAGER_TYPE;
> - } else {
> - d->type = CHAR_PAGER_TYPE;
> - }
> + d->type = CHAR_PAGER_TYPE;
Well, since it's used in some logic, it does make sense to keep it. At
least the logic should be kept anyway.
Samuel
- [PATCH 03/66] chips/busses.h: remove ifdef, (continued)
- [PATCH 04/66] ddb/db_command.c: remove forward declaration, Marin Ramesa, 2013/12/05
- [PATCH 05/66] ddb/db_command.h: remove duplicate variable declaration, Marin Ramesa, 2013/12/05
- [PATCH 07/66] ddb/db_output.c: remove duplicate function, Marin Ramesa, 2013/12/05
- [PATCH 06/66] ddb/db_output.c: remove call to nonexistent db_printf_enter(), Marin Ramesa, 2013/12/05
- [PATCH 08/66] ddb/db_output.h: add comment, Marin Ramesa, 2013/12/05
- [PATCH 09/66] device/blkio.c: remove function, Marin Ramesa, 2013/12/05
- Re: [PATCH 09/66] device/blkio.c: remove function,
Samuel Thibault <=
- [PATCH 10/66] device/chario.c: use boolean instead of an int, Marin Ramesa, 2013/12/05
- [PATCH 11/66] device/cirbuf.c: use boolean instead of an int, Marin Ramesa, 2013/12/05
- [PATCH 12/66] device/cons.h: remove ifdef, Marin Ramesa, 2013/12/05
- [PATCH 14/66] device/if_ether.h: remove unused variable, Marin Ramesa, 2013/12/05
- [PATCH 13/66] device/dev_lookup.c: remove unused lock, Marin Ramesa, 2013/12/05
- [PATCH 15/66] device/if_ether.h: remove ifdef, Marin Ramesa, 2013/12/05
- [PATCH 16/66] device/kmsg.c: use boolean instead of an int, Marin Ramesa, 2013/12/05
- [PATCH 17/66] device/kmsg.c: use boolean instead of an int, Marin Ramesa, 2013/12/05