[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 16/28] ddb/db_command.c (db_command): use db_addr_t instead o
|
From: |
Samuel Thibault |
|
Subject: |
Re: [PATCH 16/28] ddb/db_command.c (db_command): use db_addr_t instead of db_expr_t |
|
Date: |
Mon, 9 Dec 2013 00:54:30 +0900 |
|
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Marin Ramesa, le Sun 08 Dec 2013 12:40:18 +0100, a écrit :
> In this way there are two casts less.
Yes, but
> - addr = (db_expr_t)db_next;
This kind of cast is preferrable to
> + if (db_expression((db_expr_t *)&addr)) {
that one, because whatever the actual sizes, the first is correct, while
the second won't necessarily.
Samuel
- [PATCH 09/28] ddb/db_aout.c (aout_db_is_filename): remove unnecessary check, (continued)
- [PATCH 09/28] ddb/db_aout.c (aout_db_is_filename): remove unnecessary check, Marin Ramesa, 2013/12/08
- [PATCH 10/28] ddb/db_aout.c (aout_db_qualified_search): use DB_SYM_NULL as return value, Marin Ramesa, 2013/12/08
- [PATCH 11/28] ddb/db_aout.c (aout_db_lookup): remove forward declaration, Marin Ramesa, 2013/12/08
- [PATCH 12/28] ddb/db_break.c (db_add_thread_breakpoint): fix argument list, Marin Ramesa, 2013/12/08
- [PATCH 13/28] ddb/db_break.c (db_find_thread_breakpoint_here): remove unnecessary cast, Marin Ramesa, 2013/12/08
- [PATCH 14/28] i386/i386at/kd.c: use io_req instead of uio, Marin Ramesa, 2013/12/08
- [PATCH 15/28] ddb/db_command.c: use boolean values, Marin Ramesa, 2013/12/08
- [PATCH 16/28] ddb/db_command.c (db_command): use db_addr_t instead of db_expr_t, Marin Ramesa, 2013/12/08
- Re: [PATCH 16/28] ddb/db_command.c (db_command): use db_addr_t instead of db_expr_t,
Samuel Thibault <=
- [PATCH 17/28] ddb/db_command.c (db_command): remove forward declaration, Marin Ramesa, 2013/12/08
- [PATCH 18/28] ddb/db_command.c (db_command_list): remove forward declaration, Marin Ramesa, 2013/12/08
- [PATCH 19/28] ddb/db_examine.c (db_examine_cmd): remove forward declaration, Marin Ramesa, 2013/12/08
- [PATCH 20/28] ddb/db_examine.c: trivial stylistic fix for consistency, Marin Ramesa, 2013/12/08
- [PATCH 21/28] ddb/db_expr.c (db_mult_expr): remove unnecessary variable, Marin Ramesa, 2013/12/08
- [PATCH 22/28] ddb/db_expr.c (db_add_expr): remove unnecessary variable, Marin Ramesa, 2013/12/08
- [PATCH 23/28] ddb/db_mp.c: use boolean instead of an int, Marin Ramesa, 2013/12/08
- [PATCH 24/28] ddb/db_mp.c (remote_db): comment the call to cpu_interrupt_to_db(), Marin Ramesa, 2013/12/08