[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 10/13] trans: fix reference counting bug in fakeroot
From: |
Justus Winter |
Subject: |
[PATCH 10/13] trans: fix reference counting bug in fakeroot |
Date: |
Mon, 9 Dec 2013 15:16:38 +0100 |
The function new_node creates virtual nodes using netfs_make_node.
Nodes created with netfs_make_node already have a reference count of
one. Currently another reference is added in new_node. This prevents
the destruction of the node causing bugs like this:
% fakeroot-hurd sh -c 'l(){ flock /tmp/$$.lock true; }; l; l'
<hangs>
* trans/fakeroot.c (new_node): Fix reference count of newly created
nodes.
---
trans/fakeroot.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/trans/fakeroot.c b/trans/fakeroot.c
index d5cb0e6..5c4854d 100644
--- a/trans/fakeroot.c
+++ b/trans/fakeroot.c
@@ -108,10 +108,7 @@ new_node (file_t file, mach_port_t idport, int locked, int
openmodes,
pthread_mutex_lock (&idport_ihash_lock);
err = hurd_ihash_add (&idport_ihash, nn->idport, nn);
if (!err)
- {
- pthread_mutex_lock (&(*np)->lock);
- netfs_nref (*np); /* Return a reference to the caller. */
- }
+ pthread_mutex_lock (&(*np)->lock);
pthread_mutex_unlock (&idport_ihash_lock);
}
if (err)
--
1.7.10.4
- [PATCH 08/13] trans: fix reference counting and destruction of fake nodes, (continued)
- [PATCH 08/13] trans: fix reference counting and destruction of fake nodes, Justus Winter, 2013/12/09
- [PATCH 11/13] trans: improve the error handling in fakeauth, Justus Winter, 2013/12/09
- [PATCH 09/13] trans: fix locking in fakeroot's netfs_S_dir_lookup, Justus Winter, 2013/12/09
- [PATCH 12/13] trans: unlock nodes with faked attributes in fakeroot, Justus Winter, 2013/12/09
- [PATCH 05/13] trans: handle invalid responses to dir_lookup requests in fakeroot, Justus Winter, 2013/12/09
- [PATCH 10/13] trans: fix reference counting bug in fakeroot,
Justus Winter <=
- [PATCH 13/13] console-client: remove spurious pthread_spin_unlocks, Justus Winter, 2013/12/09
- Re: More fixes for fakeroot-hurd, Samuel Thibault, 2013/12/09
- [PATCH 1/5] utils/settrans: fix the teardown of chrooted environments, Justus Winter, 2013/12/10