Re: [PATCH 09/29] device/cirbuf.c (getc): use char instead of an unsigne

bug-hurd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 09/29] device/cirbuf.c (getc): use char instead of an unsigne

From:	Samuel Thibault
Subject:	Re: [PATCH 09/29] device/cirbuf.c (getc): use char instead of an unsigned char
Date:	Tue, 10 Dec 2013 00:37:21 +0100
User-agent:	Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30)

Marin Ramesa, le Mon 09 Dec 2013 23:57:24 +0100, a écrit :
> I don't understand why nr is a pointer to unsigned char.

Because of this:

>       c = *nr;

We want c to really be a value between 0 and 255, not between -128 and
127.

Samuel

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 05/29] device/blkio.c (block_io): check if io_count is larger or equal to zero, (continued)
- [PATCH 05/29] device/blkio.c (block_io): check if io_count is larger or equal to zero, Marin Ramesa, 2013/12/09
  - Re: [PATCH 05/29] device/blkio.c (block_io): check if io_count is larger or equal to zero, Samuel Thibault, 2013/12/09
    - Re: [PATCH 05/29] device/blkio.c (block_io): check if io_count is larger or equal to zero, Marin Ramesa, 2013/12/09
    - Re: [PATCH 05/29] device/blkio.c (block_io): check if io_count is larger or equal to zero, Samuel Thibault, 2013/12/10
- [PATCH 03/29] i386/i386/db_interface.c: use vm_offset_t instead of an unsigned int, Marin Ramesa, 2013/12/09
  - Re: [PATCH 03/29] i386/i386/db_interface.c: use vm_offset_t instead of an unsigned int, Samuel Thibault, 2013/12/09
- [PATCH 06/29] device/chario.c (char_write): check if io_count is larger or equal to zero and cast it to vm_size_t, Marin Ramesa, 2013/12/09
- [PATCH 07/29] device/chario.c (char_read): check if io_count is larger or equal to zero, Marin Ramesa, 2013/12/09
- [PATCH 08/29] device/chario.c: trivial stylistic fix for consistency, Marin Ramesa, 2013/12/09
- [PATCH 09/29] device/cirbuf.c (getc): use char instead of an unsigned char, Marin Ramesa, 2013/12/09
  - Re: [PATCH 09/29] device/cirbuf.c (getc): use char instead of an unsigned char, Samuel Thibault <=
- [PATCH 10/29] device/cirbuf.c (cb_alloc): use vm_size_t instead of an int, Marin Ramesa, 2013/12/09
- [PATCH 11/29] device/cirbuf.c (cb_free): use vm_size_t instead of an int, Marin Ramesa, 2013/12/09
- [PATCH 12/29] device/cons.c: fix argument list, Marin Ramesa, 2013/12/09
- [PATCH 13/29] device/dev_pager.c (device_pager_data_request): remove forward declaration, Marin Ramesa, 2013/12/09
- [PATCH 14/29] device/dev_pager.c (device_pager_data_request): cast to (void *) instead to (char *), Marin Ramesa, 2013/12/09
- [PATCH 15/29] device/dev_pager.c (device_pager_data_request_done): check if io_count is larger or equal to zero and cast it to vm_size_t, Marin Ramesa, 2013/12/09
- [PATCH 16/29] device/dev_pager.c (device_pager_data_request_done): check if io_residual is larger or equal to zero and cast it to size_t, Marin Ramesa, 2013/12/09
  - Re: [PATCH 16/29] device/dev_pager.c (device_pager_data_request_done): check if io_residual is larger or equal to zero and cast it to size_t, Samuel Thibault, 2013/12/09
- [PATCH 17/29] device/dev_pager.c (device_pager_data_request_done): remove unnecessary cast, Marin Ramesa, 2013/12/09
- [PATCH 18/29] device/dev_pager.c: remove forward declaration, Marin Ramesa, 2013/12/09

Prev by Date: Re: [PATCH 04/29] i386/i386/db_trace.c: use long instead of an int
Next by Date: Re: [PATCH 05/29] device/blkio.c (block_io): check if io_count is larger or equal to zero
Previous by thread: [PATCH 09/29] device/cirbuf.c (getc): use char instead of an unsigned char
Next by thread: [PATCH 10/29] device/cirbuf.c (cb_alloc): use vm_size_t instead of an int
Index(es):
- Date
- Thread