Re: [PATCH 3/4] kern: explain the significance of the chosen length

[Samuel Thibault]

Justus Winter, le Mon 06 Jan 2014 00:34:54 +0100, a écrit :
> * kern/slab.h (KMEM_CACHE_NAME_SIZE): Explain the significance of the
> chosen length.

Ack.

> ---
>  kern/slab.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/kern/slab.h b/kern/slab.h
> index a4219c4..fd65893 100644
> --- a/kern/slab.h
> +++ b/kern/slab.h
> @@ -147,7 +147,9 @@ typedef vm_offset_t (*kmem_slab_alloc_fn_t)(vm_size_t);
>  typedef void (*kmem_slab_free_fn_t)(vm_offset_t, vm_size_t);
>  
>  /*
> - * Cache name buffer size.
> + * Cache name buffer size.  The size is chosen so that struct
> + * kmem_cache fits into two cache lines.  The size of a cache line on
> + * a typical CPU is 64 bytes.
>   */
>  #define KMEM_CACHE_NAME_SIZE 24
>  
> -- 
> 1.8.5.2
> 

-- 
Samuel
<xterm> The problem with America is stupidity. I'm not saying there should be a 
capital punishment for stupidity, but why don't we just take the safety labels 
off of everything and let the problem solve itself?