[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 04/11] libports: lock-less reference counting for port_info o
|
From: |
Samuel Thibault |
|
Subject: |
Re: [PATCH 04/11] libports: lock-less reference counting for port_info objects |
|
Date: |
Tue, 13 May 2014 12:58:46 +0200 |
|
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Justus Winter, le Tue 13 May 2014 12:54:33 +0200, a écrit :
> I'm aware of that. Note that _ports_complete_deallocate aquires the
> _ports_htable_lock and checks if someone reacquired a reference
> through the hash table.
It should be explained how the whole figure works as a comment somewhere
in the code (perhaps along the refcounts field), because otherwise the
reader (and for now the reviewer of course) is not easily convinced that
it works, and worse, he doesn't know how he is supposed to write further
code.
Samuel
- Re: [PATCH 03/11] include: add lock-less reference counting primitives, (continued)
[PATCH 06/11] libtrivfs: lock-less reference counting for trivfs_peropen objects, Justus Winter, 2014/05/12
[PATCH 02/11] libports: use a single hash table, Justus Winter, 2014/05/12
[PATCH 04/11] libports: lock-less reference counting for port_info objects, Justus Winter, 2014/05/12
[PATCH 08/11] libihash: reduce the default maximum load factor to 75%, Justus Winter, 2014/05/12
[PATCH 11/11] fatfs: improve {enable,disable}_caching, Justus Winter, 2014/05/12
[PATCH 10/11] ext2fs: improve {enable,disable}_caching, Justus Winter, 2014/05/12
[PATCH 09/11] libihash: use linear probing and fast modulo operation, Justus Winter, 2014/05/12