[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 07/11] Avoid compiler warning about empty bodies
|
From: |
Samuel Thibault |
|
Subject: |
Re: [PATCH 07/11] Avoid compiler warning about empty bodies |
|
Date: |
Fri, 23 May 2014 00:25:21 +0200 |
|
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Justus Winter, le Thu 22 May 2014 22:13:29 +0200, a écrit :
> diff --git a/console-client/xkb/xkb.c b/console-client/xkb/xkb.c
> index 0b43913..220701b 100644
> --- a/console-client/xkb/xkb.c
> +++ b/console-client/xkb/xkb.c
> @@ -606,10 +606,11 @@ clearcontrols (keypress_t key, boolctrls ctrls, int
> flags)
> static void
> lockcontrols (keypress_t key, boolctrls ctrls, int flags)
> {
> + /* XXX this needs a closer look. */
> if (!key.rel)
> {
> //setcontrols (key, boolctrls, flags);
> - if (!(flags & noLock));
> + //if (!(flags & noLock));
> // lboolctrls |= boolctrls;
> }
> else
Comment the line, indeed, but remove the semicolon.
The rest is fine.
Samuel
- [PATCH 01/11] include: install refcount.h, Justus Winter, 2014/05/22
- [PATCH 02/11] exec: add missing includes, Justus Winter, 2014/05/22
- [PATCH 07/11] Avoid compiler warning about empty bodies, Justus Winter, 2014/05/22
- Re: [PATCH 07/11] Avoid compiler warning about empty bodies,
Samuel Thibault <=
- [PATCH 09/11] libnetfs: add netfs_make_node_alloc to allocate fat nodes, Justus Winter, 2014/05/22
- [PATCH 03/11] pfinet: add missing include, Justus Winter, 2014/05/22
- [PATCH 05/11] libdiskfs: fix type of dir_cache_id, node_cache_id, Justus Winter, 2014/05/22
- [PATCH 06/11] libstore: provide function declaration until available upstream, Justus Winter, 2014/05/22
- [PATCH 08/11] libdiskfs: add diskfs_make_node_alloc to allocate fat nodes, Justus Winter, 2014/05/22