Re: RFC: [PATCH] Re: Test case for fakeroot-hurd failure with a socket

[Svante Signell]

On Wed, 2015-05-13 at 00:52 +0200, Samuel Thibault wrote:
> Hello,
> 
> Svante Signell, le Tue 12 May 2015 22:09:33 +0200, a écrit :
> > netfs_attempt_chmod() returns an error of EOPNOTSUPP and hits the

> Err, no, see what I wrote earlier: “implement the
> netfs_set_translator stub by just calling file_set_translator on the
> underlying node to set the passive translator.” Do not overwrite
> netfs_S_file_set_translator, it'd disable everything that is done in the
> netfs_S_file_set_translator provided by libnetfs...
> 

> > +  char trans[sizeof _HURD_IFSOCK + passivelen];
> > +  memcpy (trans, _HURD_IFSOCK, sizeof _HURD_IFSOCK);
> > +  memcpy (&trans[sizeof _HURD_IFSOCK], passive, passivelen);
> 
> Err, no, don't build the translator path by hand, it's already given to
> you in the "passive" parameter! Simply pass passive and passivelen to
> file_set_translator.

New patch attached.

Explanation as follows:
Implement the netfs_set_translator stub by calling file_set_translator
on the underlying node to set the passive translator.
libnetfs/file_set_translator.c:netfs_S_file_set_translator does not
handle the case when the passive translator is a socket.

Q: Why does it work without fakeroot-hurd?

trans_fakeroot_socket.patch
Description: Text Data