Re: [PATCH] hurd: Define and pass UTIME_NOW and UTIME_OMIT to new file_utimens RPC

[Roland McGrath]

Don't repeat all that code.  Make a shared helper function _hurd_futimens
or suchlike.

> 2015-09-20  Fl?vio Cruz  <flaviocruz@gmail.com>
> 
>       Define and pass UTIME_NOW and UTIME_OMIT to new file_utimens RPC.
> 
>       * sysdeps/mach/hurd/bits/stat.h (UTIME_NOW, UTIME_OMIT): New macros.

No blank line there.  A ChangeLog paragraph (sequence with no blank lines)
covers a single logical change.  If you want to put a descriptive sentence
(not associated with a particular file) at the top of the change, then it
is the first line of the paragraph.

> --- a/sysdeps/mach/hurd/bits/stat.h
> +++ b/sysdeps/mach/hurd/bits/stat.h
> @@ -246,6 +246,10 @@ struct stat64
>  # define SF_NOUNLINK 0x00100000      /* file may not be removed or renamed */
>  # define SF_SNAPSHOT 0x00200000      /* snapshot inode */
>  
> +/* Time flags for futimens. */
> +#define UTIME_NOW   -1  /* corresponds to the current time */
> +#define UTIME_OMIT  -2  /* target time is omitted */

These should be under #ifdef __USE_ATFILE as they are in other bits/stat.h
files.  These are not "flags".  They are special values for the tv_nsec
field.  Two spaces after a period.