Re: Simple contribution please?

[Samuel Thibault]

Samuel Thibault, on Wed 17 Aug 2016 08:46:34 +0200, wrote:
> - Are we sure that the direction flag is cleared on entry of the assembly
> snippets?
> 
> - I don't think the memcmp, strlen and strcmp snippets need a memory clobber?
> 
> - the ecx trick in strlen is nice :)
> 
> - should we really use assembly snippets for strcpy and strcmp? In my
>   non-virtualized tests, a simple C loop such as
>   do { test = *dest++ = *src++; } while(test);
>   actually goes quite faster thanks to the gcc optimizer, and the
>   non-rep snippet won't buy virtualized time (and I guess we don't run
>   str functions on memory-mapped devices anyway...)

- also, in strstr, is it really better to use strncmp instead of strcmp?

Samuel