[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: BUG: /proc/self/exe reports relative paths, should always return abs
From: |
Svante Signell |
Subject: |
Re: BUG: /proc/self/exe reports relative paths, should always return absolute paths? |
Date: |
Wed, 27 Sep 2017 11:43:34 +0200 |
On Tue, 2017-09-26 at 22:07 +0200, Samuel Thibault wrote:
> Hello,
>
> This time it looks correct :)
>
> (just a couple of nitpicks which I'll just fix).
I saw that I forgot to free (cwd) immediately in execve.c. Do you want an
updated patch? Additionally I wrote in spawni.c:
/* Absolute path */
if (filename[0] == '/')
break;
/* Relative path */
else
{
...
break;
}
This could be written as
/* Relative path */
if (filename[0] != '/')
{
...
}
break;
I preferred the first version for clarity.
What else did you find? Just curious, since I did not find a commit yet.
- Re: BUG: /proc/self/exe reports relative paths, should always return absolute paths?, (continued)
- Re: BUG: /proc/self/exe reports relative paths, should always return absolute paths?, Samuel Thibault, 2017/09/22
- Re: BUG: /proc/self/exe reports relative paths, should always return absolute paths?, Svante Signell, 2017/09/24
- Re: BUG: /proc/self/exe reports relative paths, should always return absolute paths?, Samuel Thibault, 2017/09/24
- Re: BUG: /proc/self/exe reports relative paths, should always return absolute paths?, Svante Signell, 2017/09/24
- Re: BUG: /proc/self/exe reports relative paths, should always return absolute paths?, Svante Signell, 2017/09/25
- Re: BUG: /proc/self/exe reports relative paths, should always return absolute paths?, Samuel Thibault, 2017/09/25
- Re: BUG: /proc/self/exe reports relative paths, should always return absolute paths?, Svante Signell, 2017/09/26
- Re: BUG: /proc/self/exe reports relative paths, should always return absolute paths?, Samuel Thibault, 2017/09/26
- Re: BUG: /proc/self/exe reports relative paths, should always return absolute paths?, Svante Signell, 2017/09/26
- Re: BUG: /proc/self/exe reports relative paths, should always return absolute paths?, Samuel Thibault, 2017/09/26
- Re: BUG: /proc/self/exe reports relative paths, should always return absolute paths?,
Svante Signell <=
- Re: BUG: /proc/self/exe reports relative paths, should always return absolute paths?, Samuel Thibault, 2017/09/27
- Re: BUG: /proc/self/exe reports relative paths, should always return absolute paths?, Samuel Thibault, 2017/09/27
- Re: BUG: /proc/self/exe reports relative paths, should always return absolute paths?, Svante Signell, 2017/09/27
SIGILL instead of SIGSEGV: Was: Re: BUG: /proc/self/exe reports relative paths, should always return absolute paths?, Svante Signell, 2017/09/11