[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] libmachdev: Introduce startup notification for clean rump
|
From: |
Samuel Thibault |
|
Subject: |
Re: [PATCH v2] libmachdev: Introduce startup notification for clean rumpdisk shutdown |
|
Date: |
Sun, 2 Aug 2020 23:20:00 +0200 |
|
User-agent: |
NeoMutt/20170609 (1.8.3) |
Damien Zammit, le sam. 01 août 2020 15:05:38 +1000, a ecrit:
> +static void
> +device_shutdown (void)
> +{
> + struct block_data *bd = block_head;
> +
> + while (bd)
> + {
> + device_close((void *)bd);
> + bd = bd->next;
> + }
> + rump_sys_reboot (0, NULL);
> +}
Did you check that it actually flushes the disk caches? We really need
this otherwise we'll get intermitent FS corruptions.
Samuel