Re: [PATCH] SMP initialization: detection and enumeration

[Samuel Thibault]

Almudena Garcia, le mer. 12 août 2020 16:03:06 +0200, a ecrit:
> Subject: [PATCH 1/5] smp: Add pseudoclass to manage APIC operations

Applied, thanks!

> Subject: [PATCH 2/5] vm_kern: Add kmem_alloc_aligned_table

Applied and fixed a bit, thanks!

> Subject: [PATCH 3/5] smp: Add APIC finder and parser

This will have to wait for the assignment paper for Juan.

> @@ -152,6 +152,8 @@ EXTRA_DIST += \
>  
>  if PLATFORM_at
>  libkernel_a_SOURCES += \
> +     i386/i386at/acpi_parse_apic.h \
> +     i386/i386at/acpi_parse_apic.c \
>       i386/i386/apic.h \
>       i386/i386/apic.c \
>       i386/i386/hardclock.c \

Add these along the other lines adding i386/i386at files, not along the
lines adding i386/i386 files.

> From d7c1f9d043d39500ebb39b6566f55da584832480 Mon Sep 17 00:00:00 2001
> From: Almudena Garcia <liberamenso10000@gmail.com>
> Date: Wed, 12 Aug 2020 15:53:56 +0200
> Subject: [PATCH 4/5] smp: Add generic smp pseudoclass
> 
> diff --git a/i386/i386/smp.c b/i386/i386/smp.c
> new file mode 100644
> index 00000000..09e4bafa
> --- /dev/null
> +++ b/i386/i386/smp.c

> + * smp_init: initialize the SMP support, starting the cpus searching
> + * and enumeration.
> + */
> +int smp_init(void)
> +{
> +    int apic_success;
> +
> +    apic_success = acpi_apic_init();
> +    if (apic_success) {

But that will only enter if when api_success != 0, thus when we actually
have a failure. Compare explicitly against ACPI_SUCCESS

> +        smp_data_init();
> +    }
> +
> +    return apic_success;
> +}

Samuel