Re: [PATCH 2/6] fixup acpi base table search

[Samuel Thibault]

I applied it, except:

Damien Zammit, le dim. 28 mars 2021 17:03:16 +1100, a ecrit:
> @@ -421,6 +414,9 @@ acpi_apic_parse_table(struct acpi_apic *apic)
>              acpi_apic_add_irq_override(irq_override_entry);
>              break;
>  
> +        default:
> +            /* FIXME: There is another unhandled case */
> +            break;
>          }
>  
>          /* Get next APIC entry. */

You don't actually want "default: break;", since that'll precisely bury
the fact that there are unhandled cases: you're telling the compiler
that all other cases don't need anything, and prevent it from emitting a
warning that not all values of the enum are handled. Here we don't have
an enum so it doesn't matter, but if anybody was to invent one, we would
miss the warning.

Samuel