Re: Xorg bug returns: Too many files open in system

[Samuel Thibault]

Hello,

Sergey Bugaev, le sam. 06 nov. 2021 17:33:14 +0300, a ecrit:
> On Sat, Nov 6, 2021 at 3:16 PM Samuel Thibault <samuel.thibault@gnu.org> 
> wrote:
> > To exercise it you can probably move
> > sysdeps/unix/sysv/linux/tst-close_range.c to misc/,
> > and add it to tests in sysdeps/mach/hurd/Makefile too.
> 
> That doesn't seem to work: it uses support_descriptors_* () which
> walks over /proc/self/fd/ which procfs doesn't implement — though I
> guess it could, via msg_get_dtable () & msg_get_fd () and even
> FS_RETRY_MAGICAL.

It'd probably not that simple, because self/ is actually just a
magic retry on the pid variable, so in the end you'd be just opening
/proc/<callerpid>/fd. Exposing fd there with a magic retry would expose
the fd of the _caller_ in all /proc/*/, which is not what we want: we
want the fd/ there to be per-pid.

> Is there some way to add sysdep-specific implementations of support/
> functions?

I see #ifdef __linux__ there so I guess adding #ifdef __GNU__ there
would be fine.

> If not, is it still worth it to move the test to misc (and
> have it fail)?

I'd say so, so we can keep notice that there's something to fix there,
and not forget to run the tests.

I assume you have tested your glibc patch with your own baked test?

Samuel