Re: [PATCH 1/3] rumpdisk: define RUMP_REGISTER_T

[Samuel Thibault]

Hello,

A commit log message needs to include the "why" of the commit.

Damien Zammit, le sam. 18 déc. 2021 17:08:45 +1100, a ecrit:
> ---
>  rumpdisk/block-rump.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/rumpdisk/block-rump.c b/rumpdisk/block-rump.c
> index 398289fb..8c29dc01 100644
> --- a/rumpdisk/block-rump.c
> +++ b/rumpdisk/block-rump.c
> @@ -31,6 +31,7 @@
>  #include <device/device.h>
>  
>  #define MACH_INCLUDE
> +#define RUMP_REGISTER_T

I don't understand: from what I can read in rumpkernel/, RUMP_REGISTER_T
is to be the name of a type. If you define this to empty things will get
completely wrong, won't they?

Samuel