[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH glibc 12/12] C11 thrd: Downgrade the default alignment of
From: |
Samuel Thibault |
Subject: |
Re: [RFC PATCH glibc 12/12] C11 thrd: Downgrade the default alignment of mtx_t |
Date: |
Sun, 12 Feb 2023 16:18:57 +0100 |
User-agent: |
NeoMutt/20170609 (1.8.3) |
Sergey Bugaev, le dim. 12 févr. 2023 14:10:43 +0300, a ecrit:
> ..so that it can match the alignment of pthread_mutex_t on x86_64-gnu.
I'd say rather make pthread_mutex_t aligned on long int, so we can
possibly in the future put some pointers in it without breaking the ABI.
> This likely breaks many other arches (if not all of them), though.
>
> Signed-off-by: Sergey Bugaev <bugaevc@gmail.com>
> ---
> sysdeps/pthread/threads.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sysdeps/pthread/threads.h b/sysdeps/pthread/threads.h
> index 860d597d..207c1dee 100644
> --- a/sysdeps/pthread/threads.h
> +++ b/sysdeps/pthread/threads.h
> @@ -64,7 +64,7 @@ typedef __once_flag once_flag;
> typedef union
> {
> char __size[__SIZEOF_PTHREAD_MUTEX_T];
> - long int __align __LOCK_ALIGNMENT;
> + int __align __LOCK_ALIGNMENT;
> } mtx_t;
>
> typedef union
> --
> 2.39.1
- Re: [RFC PATCH glibc 9/12] mach: Look for mach_i386.defs on x86_64 too, (continued)
Re: [RFC PATCH glibc 9/12] mach: Look for mach_i386.defs on x86_64 too, Joseph Myers, 2023/02/16
[RFC PATCH glibc 4/12] hurd: Fix xattr error value, Sergey Bugaev, 2023/02/12
[RFC PATCH mig 8/12] Set max type alignment to sizeof(long), Sergey Bugaev, 2023/02/12
[RFC PATCH glibc 10/12] hurd: Set up the basic tree for x86_64-gnu, Sergey Bugaev, 2023/02/12
[RFC PATCH glibc 12/12] C11 thrd: Downgrade the default alignment of mtx_t, Sergey Bugaev, 2023/02/12
- Re: [RFC PATCH glibc 12/12] C11 thrd: Downgrade the default alignment of mtx_t,
Samuel Thibault <=
[RFC PATCH glibc 5/12] htl: Fix semaphore reference, Sergey Bugaev, 2023/02/12
[RFC PATCH glibc 11/12] hurd, htl: Add some x86_64-specific code, Sergey Bugaev, 2023/02/12
- Re: [RFC PATCH glibc 11/12] hurd, htl: Add some x86_64-specific code, Samuel Thibault, 2023/02/12
- Re: [RFC PATCH glibc 11/12] hurd, htl: Add some x86_64-specific code, Sergey Bugaev, 2023/02/12
- Re: [RFC PATCH glibc 11/12] hurd, htl: Add some x86_64-specific code, Samuel Thibault, 2023/02/12
- Re: [RFC PATCH glibc 11/12] hurd, htl: Add some x86_64-specific code, Florian Weimer, 2023/02/12
- Re: [RFC PATCH glibc 11/12] hurd, htl: Add some x86_64-specific code, Samuel Thibault, 2023/02/12