[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/4] exec: Properly preallocate address space
|
From: |
Samuel Thibault |
|
Subject: |
Re: [PATCH 4/4] exec: Properly preallocate address space |
|
Date: |
Mon, 3 Jul 2023 10:40:03 +0200 |
|
User-agent: |
NeoMutt/20170609 (1.8.3) |
Sergey Bugaev, le lun. 03 juil. 2023 11:19:54 +0300, a ecrit:
> On Mon, Jul 3, 2023 at 2:48 AM Samuel Thibault <samuel.thibault@gnu.org>
> wrote:
> > Sergey Bugaev, le lun. 26 juin 2023 02:11:37 +0300, a ecrit:
> > > @@ -1297,17 +1274,6 @@ do_exec (file_t file,
> > > finish (&interp, 1);
> > > }
> > >
> > > -
> > > - /* Leave room for mmaps etc. before PIE binaries.
> > > - * Could add address randomization here. */
> > > - anywhere_start += 128 << 20;
> >
> > This doesn't seem to appear any more in the result?
>
> I dropped it because I couldn't understand how it is useful; perhaps
> you could explain?
>
> > We need this area for mmap to go somewhere that hopefully doesn't
> > conflict with the brk.
>
> But the brk is at a fixed high address (BRK_START),
On x86_32 it's not that high.
Samuel