Re: [PATCH 2/6 gnumach] separate lapic_enable from lapic_setup

[Samuel Thibault]

Hello,

Damien Zammit, le lun. 05 févr. 2024 11:33:44 +0000, a ecrit:
> @@ -312,12 +313,10 @@ start_other_cpus(void)
>       memcpy((void*)phystokv(AP_BOOT_ADDR), (void*) &apboot,
>              (uint32_t)&apbootend - (uint32_t)&apboot);
>  
> -#ifndef APIC
> -     lapic_enable(); /* Enable lapic only once */
> -#endif
>       unsigned cpu;
>  
>       splhigh();
> +     lapic_disable();

Please add a comment why we are disabling LAPIC here.

>       bspdone = 0;
>       for (cpu = 1; cpu < ncpus; cpu++) {
> @@ -335,5 +334,6 @@ start_other_cpus(void)
>               __sync_synchronize();
>       }
>       printf("BSP: Completed SMP init\n");
> +     lapic_enable();
>  }
>  #endif       /* NCPUS > 1 */