Re: [PATCH gnumach] smp: Fix compile error with missing apboot_addr

[Almudena Garcia]

The error continues when I compile for a only cpu.

My compile commands are

./configure --host=i686-gnu CC='gcc -m32' LD='ld -melf_i386' --enable-apic --enable-kdb --enable-ncpus=1 --disable-linux-groups
make gnumach.gz

I got this error

if test -s gnumach-undef-bad; \
then cat gnumach-undef-bad; exit 2; else true; fi
apboot_addr

cpu_ap_main

El vie, 9 feb 2024 a las 8:33, Samuel Thibault (<samuel.thibault@gnu.org>) escribió:

Applied, thanks!

Damien Zammit, le ven. 09 févr. 2024 02:11:14 +0000, a ecrit:
> ---
>  i386/i386/model_dep.h | 5 +++++
>  i386/i386/mp_desc.h   | 5 -----
>  2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/i386/i386/model_dep.h b/i386/i386/model_dep.h
> index 095eec9b..5369e288 100644
> --- a/i386/i386/model_dep.h
> +++ b/i386/i386/model_dep.h
> @@ -28,6 +28,11 @@
> 
>  #include <mach/std_types.h>
> 
> +/*
> + * Address to hold AP boot code, held in ASM
> + */
> +extern phys_addr_t apboot_addr;
> +
>  /*
>   * Find devices.  The system is alive.
>   */
> diff --git a/i386/i386/mp_desc.h b/i386/i386/mp_desc.h
> index bcc68662..dc3a7dc8 100644
> --- a/i386/i386/mp_desc.h
> +++ b/i386/i386/mp_desc.h
> @@ -76,11 +76,6 @@ extern uint8_t solid_intstack[];
> 
>  extern int bspdone;
> 
> -/*
> - * Address to hold AP boot code, held in ASM
> - */
> -extern phys_addr_t apboot_addr;
> -
>  /*
>   * Each CPU calls this routine to set up its descriptor tables.
>   */
> --
> 2.43.0
>
>
>