[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/3 gnumach] vm_map: Add comment and assert for vm_map_del
|
From: |
Samuel Thibault |
|
Subject: |
Re: [PATCH v2 1/3 gnumach] vm_map: Add comment and assert for vm_map_delete |
|
Date: |
Thu, 22 Feb 2024 09:42:32 +0100 |
|
User-agent: |
NeoMutt/20170609 (1.8.3) |
Hello,
Damien Zammit, le jeu. 22 févr. 2024 08:24:25 +0000, a ecrit:
> + /*
> + * Must be called with map lock taken unless refcount is zero
> + */
> + assert((map->ref_count > 0 && map->lock.want_write) || (map->ref_count
> == 0));
Please rather use have_write_lock().
(want_write is not enough btw, want_upgrade also means we have a write
lock).
Samuel